Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inverse op and test #1592

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Add inverse op and test #1592

merged 1 commit into from
Feb 5, 2020

Conversation

JackCaoG
Copy link
Collaborator

@JackCaoG JackCaoG commented Feb 4, 2020

No description provided.

dlibenzi
dlibenzi requested changes Feb 4, 2020
View reviewed changes
Copy link
Collaborator

@dlibenzi dlibenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JackCaoG
Minor nits.

torch_xla/csrc/matrix.cpp Outdated Show resolved Hide resolved
torch_xla/csrc/ops/ops.cpp Outdated Show resolved Hide resolved
@JackCaoG
Add inverse op and test
9cac35f 
minor format change
@dlibenzi
Copy link
Collaborator

dlibenzi commented Feb 5, 2020

@JackCaoG Did this pass on TPU?

@JackCaoG
Copy link
Collaborator Author

JackCaoG commented Feb 5, 2020 •
edited
Loading

@dlibenzi Run into some issue with the vms, after certain steps I perform, I won't be able to ssh onto the vm anymore( ssh hangs forever ). Will keep work on it today..

@dlibenzi dlibenzi merged commit 86d3c70 into master Feb 5, 2020
@dlibenzi dlibenzi deleted the inverseop branch February 5, 2020 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlibenzi dlibenzi dlibenzi approved these changes

Assignees
No one assigned
Labels
op lowering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JackCaoG @dlibenzi